Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): update cairo native version to v0.2.3 #2190

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

varex83
Copy link
Contributor

@varex83 varex83 commented Nov 19, 2024

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@varex83 varex83 added the native integration Related with the integration of Cairo Native into the Blockifier label Nov 19, 2024
Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.46%. Comparing base (e3165c4) to head (fc61427).
Report is 512 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2190       +/-   ##
===========================================
+ Coverage   40.10%   77.46%   +37.35%     
===========================================
  Files          26      385      +359     
  Lines        1895    40472    +38577     
  Branches     1895    40472    +38577     
===========================================
+ Hits          760    31351    +30591     
- Misses       1100     6813     +5713     
- Partials       35     2308     +2273     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rodrigo-pino rodrigo-pino marked this pull request as ready for review November 19, 2024 22:59
Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @varex83)


crates/starknet_sierra_compile/build.rs line 41 at r1 (raw file):

    // Set the runtime library path. This is required for Cairo native compilation.
    let runtime_library_path = repo_root_dir()
        .join("crates/blockifier/cairo_native/target/release/libcairo_native_runtime.a");

Why did the path change?

Code quote:

 .join("crates/blockifier/cairo_native/target/release/libcairo_native_runtime.a");

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @varex83)

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @varex83)

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware)

@Yoni-Starkware Yoni-Starkware merged commit fbbb6c5 into main Nov 20, 2024
22 checks passed
@Yoni-Starkware Yoni-Starkware deleted the bohdan/cn-0.2.3 branch November 20, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
native integration Related with the integration of Cairo Native into the Blockifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants